Hello! On Sat, May 05, 2007 at 02:54:46PM +0200, Samuel Thibault wrote: > Thomas Schwinge, le Sat 05 May 2007 14:14:31 +0200, a ?crit : > > void halt_cpu(void) > > { > > asm volatile("cli"); > > - while(1); > > + while (TRUE) > > + machine_idle (cpu_number ()); > > } > > Should be fine. > > > @@ -172,8 +171,8 @@ void halt_all_cpus(reboot) > > printf("In tight loop: hit ctl-alt-del to reboot\n"); > > (void) spl0(); > > } > > - for (;;) > > - continue; > > + while (TRUE) > > + machine_idle (cpu_number ()); > > } > > Shouldn't this be a call to halt_cpu()?
No, I wouldn't think so, because that function's `cli' instruction would prevent us from being able to catch keyboard interrupts in order to serve the user's request to reboot the system. Who has an idea about a (name for a new) file to put prototyes for all these `halt_*' functions and friends in? `kern/machine.h'? But `kern/machine.c' is used for other things. Regards, Thomas
signature.asc
Description: Digital signature
_______________________________________________ Bug-hurd mailing list Bug-hurd@gnu.org http://lists.gnu.org/mailman/listinfo/bug-hurd