On 06.12.2013 16:29:56, Marin Ramesa wrote: > This patch has one questionable addition, that is the cast from > io_req_t to a pointer to uio struct in the function kdread(). > [...] > - return((*linesw[kd_tty.t_line].l_read)(tp, uio)); > + return((*linesw[kd_tty.t_line].l_read)(tp, (struct uio *)uio)); >
This is an unnecessary cast. I've just read device/buf.h and uio is defined as io_req. I will send a patch removing the uio structure and using io_req_t instead of it.