Re: Conflicting ‘thread_info_t’ declaration between nscd and Mach

[Ludovic Courtès]

Roland McGrath <rol...@hack.frob.com> skribis:

> Send a patch upstream to libc to avoid using the *_t name space for
> non-public type names like the one in nscd.  We'll take it.

Great, will do.

Manolis: could you confirm that the attached patch allows you to build
libc for the Hurd with nscd support?


diff --git a/nscd/nscd.c b/nscd/nscd.c
index 5680378..c910fd5 100644
--- a/nscd/nscd.c
+++ b/nscd/nscd.c
@@ -61,14 +61,14 @@
    and under a shutdown condition to wait till all in-progress
    requests have finished before "turning off the lights".  */
 
-typedef struct
+struct thread_info
 {
   int             num_active;
   pthread_cond_t  thread_exit_cv;
   pthread_mutex_t mutex;
-} thread_info_t;
+};
 
-thread_info_t thread_info;
+struct thread_info thread_info;
 
 int do_shutdown;
 int disabled_passwd;

If it does, let’s do that in Guix.

Thanks,
Ludo’.