Hello, On 25 March 2015 at 01:39, Samuel Thibault <samuel.thiba...@gnu.org> wrote: > This was not up to date to some oddness in the tls-threadvar branch, but > I've now fixed it, and thus contains the fix from the corresponding > branch.
Thank you. > BTW, I think the latest libpthread source will save you some unnecessary > burden about libpthead bits/ headers which would previously have to be > installed before building glibc. Thank you Samuel, this is really appreciated! Ludovic was telling me a couple of days ago, that maybe we should consider hosting somewhere, a tar version of glibc and libpthread with the latest updates. This will make our lifes much easier. WDYT? And one more thing. In libpthread commit 44ae774bed1a75ea926590f1bc7c9f3328219832 you pushed -#ifdef IS_IN_libpthread +#if IS_IN (libpthread) But it ends failing with ./pthread/pt-internal.h:38:11: error: missing binary operator before token "(" #if IS_IN (libpthread) ^ Attaching build log. Thank you, Manolis
In file included from ./pthread/../sysdeps/generic/pt-attr.c:25:0: ./pthread/pt-internal.h:38:11: error: missing binary operator before token "(" #if IS_IN (libpthread) ^ ./pthread/pt-internal.h:63:13: error: missing binary operator before token "(" #if !(IS_IN (libpthread)) ^ ./pthread/pt-internal.h:63:13: error: missing binary operator before token "(" #if !(IS_IN (libpthread)) ^ In file included from ./pthread/../sysdeps/generic/pt-attr-getinheritsched.c:21:0: ./pthread/pt-internal.h:38:11: error: missing binary operator before token "(" #if IS_IN (libpthread) ^ ./pthread/pt-internal.h:63:13: error: missing binary operator before token "(" #if !(IS_IN (libpthread)) ^ In file included from ./pthread/../sysdeps/generic/pt-attr-getschedparam.c:24:0: ./pthread/pt-internal.h:38:11: error: missing binary operator before token "(" #if IS_IN (libpthread) ^ ./pthread/pt-internal.h:63:13: error: missing binary operator before token "(" #if !(IS_IN (libpthread)) ^ In file included from ./pthread/../sysdeps/generic/pt-attr-getscope.c:21:0: ./pthread/pt-internal.h:38:11: error: missing binary operator before token "(" #if IS_IN (libpthread) ^ In file included from ./pthread/../sysdeps/generic/pt-attr-getschedpolicy.c:21:0: ./pthread/pt-internal.h:38:11: error: missing binary operator before token "(" #if IS_IN (libpthread) ^ ./pthread/pt-internal.h:63:13: error: missing binary operator before token "(" #if !(IS_IN (libpthread)) ^ ./pthread/pt-internal.h:63:13: error: missing binary operator before token "(" #if !(IS_IN (libpthread)) ^ In file included from ./pthread/../sysdeps/generic/pt-attr-getdetachstate.c:21:0: ./pthread/pt-internal.h:38:11: error: missing binary operator before token "(" #if IS_IN (libpthread) ^ ./pthread/pt-internal.h:63:13: error: missing binary operator before token "(" #if !(IS_IN (libpthread)) ^ /tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/sysd-rules:2439: recipe for target '/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-destroy.o' failed make[2]: *** [/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-destroy.o] Error 1 make[2]: *** Waiting for unfinished jobs.... /tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/sysd-rules:2439: recipe for target '/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr.o' failed make[2]: *** [/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr.o] Error 1 In file included from ./pthread/../sysdeps/generic/pt-attr-getguardsize.c:21:0: ./pthread/pt-internal.h:38:11: error: missing binary operator before token "(" #if IS_IN (libpthread) ^ /tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/sysd-rules:2439: recipe for target '/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getschedpolicy.o' failed make[2]: *** [/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getschedpolicy.o] Error 1 ./pthread/pt-internal.h:63:13: error: missing binary operator before token "(" #if !(IS_IN (libpthread)) ^ /tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/sysd-rules:2439: recipe for target '/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getschedparam.o' failed make[2]: *** [/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getschedparam.o] Error 1 /tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/sysd-rules:2439: recipe for target '/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getscope.o' failed make[2]: *** [/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getscope.o] Error 1 /tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/sysd-rules:2439: recipe for target '/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getinheritsched.o' failed make[2]: *** [/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getinheritsched.o] Error 1 /tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/sysd-rules:2439: recipe for target '/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getdetachstate.o' failed make[2]: *** [/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getdetachstate.o] Error 1 /tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/sysd-rules:2439: recipe for target '/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getguardsize.o' failed make[2]: *** [/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getguardsize.o] Error 1 make[2]: Leaving directory '/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/glibc-hurd-2.18/libpthread' Makefile:213: recipe for target 'libpthread/others' failed make[1]: *** [libpthread/others] Error 2 make[1]: Leaving directory '/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/glibc-hurd-2.18' Makefile:9: recipe for target 'all' failed make: *** [all] Error 2 phase `build' failed after 143 seconds