Svante Signell, le Wed 13 May 2015 10:31:42 +0200, a écrit : > On Wed, 2015-05-13 at 10:04 +0200, Samuel Thibault wrote: > > Samuel Thibault, le Wed 13 May 2015 09:57:27 +0200, a écrit : > > > > + return file_set_translator (netfs_node_netnode (np)->file, > > > > + FS_TRANS_EXCL|FS_TRANS_SET, > > > > + FS_TRANS_EXCL|FS_TRANS_SET, 0, > > > > + argz, argzlen, > > > > + MACH_PORT_NULL, MACH_MSG_TYPE_COPY_SEND); > > > > > > Mmm, I don't think you want to set the active_flags parameter, see the > > > comment above: > > > > And you have set the active parameter to MACH_PORT_NULL, so active_flags > > should really be set to 0, it doesn't really make sense otherwise. > > This is copeied verbatim from fakeroot.c:netfs_attempt_mksymlink() and > netfs_attempt_mkdev() so the active_flags parameter should be zero there > too?
Mmm, thinking about it more, making it MACH_PORT_NULL can actually make sense: it'll make any existing active translator go away, which is perhaps a good thing actually. Samuel
