Samuel Thibault <samuel.thiba...@gnu.org> writes:
> Joshua Branson, le ven. 09 nov. 2018 11:59:31 -0500, a ecrit:
>> > It's correct, but could be improved: I'd say rather take the example of
>> > glibc's send(), which is an RPC handled by pfinet, which uses a
>> > device_write RPC to actually emit an Ethernet frame, which is handled by
>> > netdde, which pushes the hardware, and gets an interrupt from GNU Mach
>> > when that's done.
>>
>> I think the new attached patch shows that, but I'm not an expert.
>
> It's more interesting, yet not as good as it could :)
I decided to add in some color to the image. Let me know what you
think.
>From 679531c567607d3fbd67cfd619ff9e9ba613cb87 Mon Sep 17 00:00:00 2001
From: Joshua Branson <jbra...@fastmail.com>
Date: Sat, 10 Nov 2018 11:37:02 -0500
Subject: [PATCH] I added some color to the anatomy image.
---
open_issues/images/overview.svg | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/open_issues/images/overview.svg b/open_issues/images/overview.svg
index 0cd36c0d..bd47da91 100644
--- a/open_issues/images/overview.svg
+++ b/open_issues/images/overview.svg
@@ -300,7 +300,7 @@
x="80"
y="178.91158" /></flowRegion><flowPara
id="flowPara4547"></flowPara></flowRoot> <rect
- style="fill:none;fill-opacity:1;stroke:#000000;stroke-width:0.5;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1"
+ style="fill:#86ee73;fill-opacity:1;stroke:#000000;stroke-width:0.5;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1"
id="rect4553"
width="153.78763"
height="42.85815"
@@ -309,14 +309,14 @@
inkscape:transform-center-x="4.3782942"
inkscape:transform-center-y="2.4590809" />
<rect
- style="fill:none;fill-opacity:1;stroke:#000000;stroke-width:0.47089785;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1"
+ style="fill:#c7c5f8;fill-opacity:1;stroke:#000000;stroke-width:0.47089785;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1"
id="rect4555"
width="65.128036"
height="17.881008"
x="81.836281"
y="229.65338" />
<rect
- style="fill:none;fill-opacity:1;stroke:#000000;stroke-width:0.5;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1"
+ style="fill:#e7ee73;fill-opacity:1;stroke:#000000;stroke-width:0.5;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1"
id="rect4557"
width="154.77304"
height="15.707925"
@@ -339,7 +339,7 @@
height="16.92679"
width="154.59225"
id="rect4575"
- style="fill:none;fill-opacity:1;stroke:#000000;stroke-width:0.5;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1" />
+ style="fill:#ae73ee;fill-opacity:1;stroke:#000000;stroke-width:0.5;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1" />
<rect
style="fill:none;fill-opacity:1;stroke:#000000;stroke-width:0.5;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1"
id="rect4585"
--
2.19.1
>
>> + ---------------------------------------
>> + | \ Hurd Servers |
>> + | | |
>> + | | auth and other servers|
>> + | | |
>> + | pfinet -> device_write RPC |
>> + | \ | |
>> + | \ | |
>> + | \ | |
>> + --------------------------------------
>> + \ /
>> + \ netdde
>
> netdde is actually one of the hurd servers. I'd say either drop the Hurd
> Servers frame and use frames around pfinet and netdde, or keep the Hurd
> Servers frame, but put frames around pfinet and netdde. Otherwise it's
> misguiding, the reader could think that the "Hurd Servers" is just one
> process.
>
> pfinet itself doesn't talk with GNU Mach, it really only uses
> device_write implemented by netdde, which pushes to the hardware (after
> asking GNU Mach for permission)
>
> Samuel
