> > I don't recommend leaving it up for later like this, or at least put a > fat XXX that you will remember. >
Thanks for the tip. I'll add a TODO label in the blocks to replace. This work (to recover old APIC structures and cpu_number()) is a previous step to implement cpus enumeration. The real LAPIC address will be get from ACPI tables during cpus enumeration, which will be implemented soon, El vie., 15 feb. 2019 a las 17:23, Samuel Thibault (<samuel.thiba...@gnu.org>) escribió: > Almudena Garcia, le ven. 15 févr. 2019 17:11:04 +0100, a ecrit: > > And now It compiles. Probably It will not work yet, because the APIC > Table > > address could be not correct, but these can be fixed in other time. > > I don't recommend leaving it up for later like this, or at least put a > fat XXX that you will remember. > > This kind of leaving problems under the carpet *always* bite sooner or > later (hopefully sooner so that you remember about it). > > Getting the thing to compile is a good thing, but writing the correct > things is a really important one before proceeding further, notably for > such ground bits. > > Samuel >
