On Sat, May 1, 2021 at 6:23 PM Samuel Thibault <samuel.thiba...@gnu.org> wrote: > This is missing the copyright head:ng.
Ah yes, sorry. Should I just put myself there, or "Hurd developers", or "Free Software Foundation, Inc."?.. > > + err = create_pager (node, &obj); > > Is the pager getting cleaned at some point? The idea was that NODE_INFO(node)->pager does *not* itself keep a hard reference on the pager (create_pager () calls ports_port_deref (pager) after pager_get_port ()), so once all the pager clients are gone, the memory object would get garbage-collected, which would call pager_clear_user_data (), which sets NODE_INFO(node)->pager = NULL. But I was unable to test this in practice: Mach doesn't seem to want to do memory_object_terminate () even after the clients are gone. Perhaps it wants to keep the page cached while it has enough free memory. -- Sergey