Sergey Bugaev, le dim. 12 févr. 2023 19:13:58 +0300, a ecrit: > On Sun, Feb 12, 2023 at 6:22 PM Samuel Thibault <samuel.thiba...@gnu.org> > wrote: > > I'd rather say drop the "long" part, to avoid having to pull the > > stdint.h header in. > > That's what I meant, yes. > > > Nowadays' BSD headers just use the int type, > > notably. > > So given that the Linux port has its own bits/termios.h, is it fine to > just modify the generic one inline, rather than creating a > Hurd-specific version?
Yes. > The patch for that follows. > > Sergey > > -- >8 -- > > From 625b774141823a8f504cce8a92b9f45f5e6f050f Mon Sep 17 00:00:00 2001 > From: Sergey Bugaev <buga...@gmail.com> > Date: Sun, 12 Feb 2023 19:08:57 +0300 > Subject: [PATCH] hurd: Fix tcflag_t and speed_t types on 64-bit > > These are supposed to stay 32-bit even on 64-bit systems. This matches > BSD and Linux, as well as how these types are already defined in > tioctl.defs > > Signed-off-by: Sergey Bugaev <buga...@gmail.com> > --- > bits/termios.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/bits/termios.h b/bits/termios.h > index 4439c2f1..6a883ceb 100644 > --- a/bits/termios.h > +++ b/bits/termios.h > @@ -99,13 +99,13 @@ > `tcflag_t', `cc_t', `speed_t' and the `TC*' constants appropriately. */ > > /* Type of terminal control flag masks. */ > -typedef unsigned long int tcflag_t; > +typedef unsigned int tcflag_t; > > /* Type of control characters. */ > typedef unsigned char cc_t; > > /* Type of baud rate specifiers. */ > -typedef long int speed_t; > +typedef int speed_t; > > /* Terminal control structure. */ > struct termios > -- > 2.39.1 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.
