On Mon, Apr 3, 2023 at 2:20 AM Samuel Thibault <samuel.thiba...@gnu.org> wrote: > Sergey Bugaev, le dim. 19 mars 2023 18:10:06 +0300, a ecrit: > > Nothing in there needs tls.h > > Ok but includers might be erroneously relying on it. Did you try to > build various configurations, to make sure that this isn't breaking any?
There (unfortunately) still are multiple other ways that <ldsodefs.h> ends up including <tls.h> (in particular through <link.h>), so this change should not immediately break anything. See the cover letter for some more details about this. That being said, it sounds like glibc would benefit from a run of https://include-what-you-use.org/ over the code base. This would both trim the extraneous includes (such as this #include <tls.h>) and add the ones that are required, but (as you're saying, erroneously) not explicitly mentioned. Sergey
