Re: [PATCH v2 1/4 gnumach] separate lapic_enable from lapic_setup

[Samuel Thibault]

Damien Zammit, le mar. 06 févr. 2024 03:06:17 +0000, a ecrit:
>       splhigh();
>  
> +     /* Disable IOAPIC interrupts (IPIs not affected).
> +      * Clearing this flag is similar to masking all
> +      * IOAPIC interrupts individually */

This is not saying _why_ we do this.  Why IOAPIC would be a problem
while booting the APs.

Remember that most of the comments of people reading code is "why on
earth are they doing that?!".

> +     lapic_disable();
> +
>       bspdone = 0;
>       for (cpu = 1; cpu < ncpus; cpu++) {
>               machine_slot[cpu].running = FALSE;