On 20 June 2026 14:53:30 BST, Samuel Thibault <[email protected]> wrote: >Hello, > >Damien Zammit, le sam. 20 juin 2026 02:11:04 +0000, a ecrit: >> This change allows cross compilation of the test suite from a >> non-x86 GNU/Linux host. > >What does this actually fix?
Hi, I'm guessing here but I'm thinking it's fixing the include errors that happen on non X86 systems? >$(MACH_TESTINSTALL) already integrates the headers that gnumach >installs. What more do tests need that aren't available that way? > >As in: it's probably a sign that we are perhaps not installing something >that we should, or some such. >Possibly there is some header that tests do need and we don't want to >install. But exposing the whole include/ is not the proper way to fix >it, since then we wouldn't be catching the case that we miss installing >a new header that userland needs. Damien, what do you think here? :) >Samuel > >> --- >> tests/user-qemu.mk | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tests/user-qemu.mk b/tests/user-qemu.mk >> index 857dbaac..e497ca6d 100644 >> --- a/tests/user-qemu.mk >> +++ b/tests/user-qemu.mk >> @@ -115,6 +115,7 @@ TESTCFLAGS = -static -nostartfiles -nolibc \ >> -I$(srcdir)/tests/include \ >> -I$(MACH_TESTINCLUDE) \ >> -I$(MIG_OUTDIR) \ >> + -I$(srcdir)/include \ >> -ggdb3 \ >> -DMIG_EOPNOTSUPP >> >> -- >> 2.49.0 >> >> >> > > Thanks!
