Hello Samuel,

I just saw that you made the adjustments and merged the fix—thank you for
doing that, I really appreciate it!
You are right. After looking closer at `libdiskfs/init-startup.c`, I saw
exactly what you meant about the framework already handling the mount-time
dirtying naturally via `diskfs_set_hypermetadata(0, 0)`, making the extra
call in `main()` completely redundant.
I appreciate you catching that and keeping the Hurd's lazy I/O philosophy
intact.

Question about how you get it to lock up? Is your root system also
journaled and then you do a massive apt upgrade? I tried that and it didn't
lock up or get corrution (either update wasn't big enough, or something
else is happening).

Thanks again,
Milos


On Tue, Sep 1, 2026 at 2:49 PM Samuel Thibault <[email protected]>
wrote:

> Hello,
>
> Milos Nikic, le lun. 31 août 2026 17:04:01 -0700, a ecrit:
> > diff --git a/ext2fs/ext2fs.c b/ext2fs/ext2fs.c
> > index 984df0448..469a7f132 100644
> > --- a/ext2fs/ext2fs.c
> > +++ b/ext2fs/ext2fs.c
> > @@ -268,7 +268,12 @@ main (int argc, char **argv)
> >        {
> >         ext2_journal = journal_create (jnode);
> >         if (ext2_journal)
> > -         fprintf (stderr, "ext2fs: journaling enabled on %s\n",
> diskfs_disk_name);
> > +      {
> > +        fprintf (stderr, "ext2fs: journaling enabled on %s\n",
> diskfs_disk_name);
> > +        /* Immediately mark the filesystem dirty and set needs_recovery
> on disk */
> > +        if (!diskfs_readonly)
> > +          diskfs_set_hypermetadata (1, 0);
>
> I don't understand why doing this? As long as we have not written
> anything, the filesystem is clean?
>
> Samuel
>

Reply via email to