Howdy y'all, Just wanted to send over the next series of patches I've made. :) I noticed that when my initial patchset was imported some of the regression tests didn't survive the import process, and for your convenience, that's covered by one of the patches herein. I had forgotten to send one, for which I sent another patch the other day.
Now, on to the new stuff. Following the email from Sami Liedes, I took a look at his test corpora for afl-fuzz and fixed the bug in the comment stuff. Thereafter I did my own run of afl-fuzz, and after nearly 10 hours, I found some inputs that were causing corruption of the heap control structures. Those are also fixed, and I added a test case for both cases. Just for reference, Sami's email is here: http://lists.gnu.org/archive/html/bug-indent/2015-03/msg00004.html I also did some work on fixing potential memory leaks, fixed the issue that Clark Wang was having (at least I can no longer reproduce it) and added a testcase for that. Additionally, I fixed an issue with recognition of function pointer declarations wiht multiple levels of indirection, introduced an option to not auto-align comments within a line of code to the nearest tabstop and added an install target to the regression Makefile so that 'make install' won't fail. Enjoy! Tim Tim Hentenaar (9): Add regressions mising from upstream comments.c: Fix print_comment reading past the end of the buffer when reading less than a full comment from stdin. Fix several potential memory leaks scan_profile(): Make sure the buffers are initialized comments.c: Fix heap corruption indent.c: Don't force nl between rbrace and comma Don't tab-align comments (-ntac) -npcs: Fix recognition of function pointers Add an install target to the regression Makefile ChangeLog | 24 +++++++++++++ doc/indent.texi | 12 ++++++- regression/Makefile | 6 +++- regression/TEST | 22 ++++++++++-- regression/input/block-comments.c | 16 +++++++++ regression/input/combuf-heap-corruption | 1 + regression/input/dont-tab-align-comments.c | 7 ++++ regression/input/fp.c | 1 + regression/input/no-forced-nl-in-block-init.c | 14 ++++++++ .../input/preserve-newline-after-right-brace.c | 17 +++++++++ regression/standard/block-comments.c | 17 +++++++++ regression/standard/dont-tab-align-comments.c | 8 +++++ regression/standard/fp.c | 1 + regression/standard/no-forced-nl-in-block-init.c | 16 +++++++++ regression/standard/no-space-after-fp-name.c | 1 + .../standard/preserve-newline-after-right-brace.c | 18 ++++++++++ src/args.c | 40 +++++++++++---------- src/code_io.c | 18 +++++----- src/comments.c | 24 ++++++++----- src/globs.c | 32 +++++++++++++++-- src/globs.h | 6 ++++ src/handletoken.c | 6 ++-- src/indent.c | 42 +++++++++++++++------- src/indent.h | 1 + src/lexi.c | 13 +++++++ src/lexi.h | 1 + src/output.c | 3 +- src/parse.c | 23 ++++++++++++ src/parse.h | 1 + src/utils.c | 3 +- 30 files changed, 335 insertions(+), 59 deletions(-) create mode 100644 regression/input/block-comments.c create mode 100644 regression/input/combuf-heap-corruption create mode 100644 regression/input/dont-tab-align-comments.c create mode 100644 regression/input/no-forced-nl-in-block-init.c create mode 100644 regression/input/preserve-newline-after-right-brace.c create mode 100644 regression/standard/block-comments.c create mode 100644 regression/standard/dont-tab-align-comments.c create mode 100644 regression/standard/no-forced-nl-in-block-init.c create mode 100644 regression/standard/preserve-newline-after-right-brace.c -- 2.3.6 _______________________________________________ bug-indent mailing list [email protected] https://lists.gnu.org/mailman/listinfo/bug-indent
