2009/10/4 Alfred M. Szmidt wrote: > Here [2] is a patch for --deadline/-w option, and need suggestions ? > > The option name is not very good, I had to read the patch to see what > it actually does. Please make sure that the short option have the > same behaviour as BSD ping. I would suggest --timeout=N. Also please > update the NEWS file, and the ping manual accordingly. >
Thanks for all suggestions, I will update NEWS file and ping manual. Regarding option name BSD one has --deadline option for this (timeout before ping exits) and timeout for 'time to wait for a response'. So I guess it would nice to keep the options same. [..] > unsigned long preload = 0; > +int deadline = DEFAULT_DEADLINE; > > Both the otion name and variable name are terrible since the word > deadline does not convey anything about that this just aborts ping > after N seconds. > May you suggest one or two if you have in mind ? This name seems somewhat apt to me, but better name would obviously be good. timeout wouldn't be okay in my opinion as it should be a different option (BSD behaviour). [..] > + break; > > Please add a check so that this is only done in the case when a user > uses this options. The indentation is also messed up... > > Same applies for ping6. > I will update with all other fixes and additions suggested, thanks. -- Rakesh Pandit https://fedoraproject.org/ freedom, friends, features, first
