Hi Alfred, [email protected] (Alfred M. Szmidt) skribis:
> How about this patch instead, this doesn't fix Rob's timeouts but it > does make the test suite more robust on systems that do not have > netstat installed. > > diff --git a/tests/tftp.sh b/tests/tftp.sh > index fec5171..964c096 100755 > --- a/tests/tftp.sh > +++ b/tests/tftp.sh [...] > +# Check existance of netstat before proceeding. > +netstat > /dev/null > +if [ ! $? -eq 0 ]; then > + echo "netstat is required" > + exit 77 > +fi Sounds good to me, though it doesn’t allow you to distinguish between “not found” and some other netstat failure (unlike AC_PATH_PROG([NETSTAT], [netstat]) + @NETSTAT@.) Thanks, Ludo’.
