On 10/13/21 5:25 AM, Yuchen Pei wrote:> > jahoti <[email protected]> writes: > >> On 10/13/21 3:32 AM, Yuchen Pei wrote: >>> If we were to evaluate pagure.io based on the ethical repository >>> criteria[1] it would probably get an F for failing C0, because with >>> LibreJS on I couldn't register a new account, nor could I create a >>> pull request. >> >> Couldn't you? > > When I tried to register, I couldn't navigate to the "register tab" from > the "login tab".Thank you for the correction! It seems I forgot about that (disabling CSS fixes the problem).
> After a second look, I was not sure about creating a pull request. When > I click "create a pull request", I see an empty page, with 10 scripts > blocked. But that could also be I don't have a commit on my fork yet. > > So I tried to push my commit to my fork so that I can create a PR, but > that seems to require adding an ssh key, which I cannot do with LibreJS > on: clicking "Add SSH key" does nothing. > > I went to private browsing where librejs is disabled to add a key, > pushed my commit to my fork[1], and came back to my main browser without > private browsing. I am still not able to create a PR, as the button is > disabled, and "Files changed" and "Commits" both show a count of 0 - see > the attached screenshot. > > [1]:> https://pagure.io/fork/ycp/librejs/c/fadb9a896a11ba929476cc5adb5f4a35815cedd0?branch=fix-json-parsing I must shamefully admit to having completely overlooked the part about pull requests in the original e-mail. Nevertheless, thank you for investigating so thoroughly; it is extremely helpful, as it saves me the futility of trying to make any PRs there.
OpenPGP_signature
Description: OpenPGP digital signature
