Ralf Wildenhues wrote on Thursday, September 22, 2005 08:36 CEST: > Hi Peter, > > * Peter Ekberg wrote on Wed, Sep 21, 2005 at 03:33:23PM CEST: > > * Ralf Wildenhues wrote on Tuesday, September 20, 2005 16:20 CEST: > > > * Peter Ekberg wrote on Tue, Sep 20, 2005 at 03:25:01PM CEST: > > > > > > > > The recent change to bug out when the exit code is non-zero [1] > > > > uncovered a silent failure on Cygwin (an MinGW I suppose) in > > > > the link-order.at test. > > > > So this reveals that we are testing something slightly different: > > > we install both liba versions before linking against > them. What we > > > should be doing according to the bug report: link and > install the old > > > version, then `$LIBTOOL --mode=clean' the old library, > link the new > > > library, link the program, execute the uninstalled, install both, > > > execute again. > > > > It's not as bad as it seems. Normal operation would be: > > > > ... > > 6. main_old is executed and terminates with 0 exit code > > 7. main_new is linked against new/lib/liba > > 8. main_new is executed and terminates with 0 exit code > > > > So the test links with old liba after new liba is installed, that > > is in addition to what you specify. But it doesn't test with > > the uninstalled new liba or the installed main_new. > > OK. I'd still like to eventually make it test what I outlined above > (as that might just uncover another failure). > > > > Then we should make sure that, if we undo the patch from Alexandre > > > that was installed, the test fails. Actually, come to > think of it, > > > we should make sure it fails even without the EGREP test. > > > I think this patch is less intrusive and more obvious to not > > disrupt the test. > > This is obviously better than what we have now. Please install, > and copy a patch to libtool-patches. ;-) > > Thanks! > Ralf > > > * tests/link-order.test: Clean up the uninstalled libraries > > before linking the test executables so that they don't pick > > up the dlls from the current dir on Cygwin and MinGW. > >
Great, commited this: Index: link-order.at =================================================================== RCS file: /cvsroot/libtool/libtool/tests/link-order.at,v retrieving revision 1.4 diff -u -r1.4 link-order.at --- link-order.at 13 Aug 2005 06:57:39 -0000 1.4 +++ link-order.at 21 Sep 2005 13:19:14 -0000 @@ -61,6 +61,9 @@ [0], [stdout], [stderr]) done +$LIBTOOL --mode=clean rm -f src/libb.la +$LIBTOOL --mode=clean rm -f src/liba.la + # Do not error if we do not relink (e.g. static-only systems) AT_CHECK([if $EGREP relinking stderr; then $EGREP ' -L.*\/new\/lib -lb -L.*\/old\/lib -lcee' stdout _______________________________________________ Bug-libtool mailing list Bug-libtool@gnu.org http://lists.gnu.org/mailman/listinfo/bug-libtool