Status: Accepted
Owner: ----
Labels: Type-Build Priority-High Patch-new
New issue 1799 by mts...@gmail.com: output-distance.py does not parse
scheme nan values correctly
http://code.google.com/p/lilypond/issues/detail?id=1799
nan values in scheme are issued as +nan.0 and -nan.0, which Python doesn't
understand. This patch at fixes the parsing, although I'm not sure if
other parts of output-distance.py are not nan friendly as well (and I
wouldn't know how to check how it handles nan once nan is parsed - someone
who knows output-distance.py better than I would need to help me
understand what type of input it expects). The issue creeped up when I was
running regtests on a patch.
Patch at http://codereview.appspot.com/4835049/
I'm marking this as high priority, but it could be considered critical
insofar as it will always crash the build system when +nan.0 or -nan.0 is
encountered.
Original problem from:
Traceback (most recent call last):
File "/home/mikesol/lilypond-reg/scripts/build/out/output-distance", line
1261, in <module>
main ()
File "/home/mikesol/lilypond-reg/scripts/build/out/output-distance", line
1258, in main
compare_tree_pairs (zip (args[0::2], args[1::2]), out,
options.threshold)
File "/home/mikesol/lilypond-reg/scripts/build/out/output-distance", line
970, in compare_tree_pairs
data.compare_trees (dir1, dir2)
File "/home/mikesol/lilypond-reg/scripts/build/out/output-distance", line
810, in compare_trees
self.compare_directories (dir1, dir2)
File "/home/mikesol/lilypond-reg/scripts/build/out/output-distance", line
841, in compare_directories
self.compare_files (f1, f2)
File "/home/mikesol/lilypond-reg/scripts/build/out/output-distance", line
845, in compare_files
self.compare_signature_files (f1, f2)
File "/home/mikesol/lilypond-reg/scripts/build/out/output-distance", line
877, in compare_signature_files
file_link.add_file_compare (f1, f2)
File "/home/mikesol/lilypond-reg/scripts/build/out/output-distance", line
596, in add_file_compare
s2 = read_signature_file (f2)
File "/home/mikesol/lilypond-reg/scripts/build/out/output-distance", line
331, in read_signature_file
if e and not e.startswith ('#')]
File "/home/mikesol/lilypond-reg/scripts/build/out/output-distance", line
325, in string_to_entry
fields[2] = string_to_tup (fields[2])
File "/home/mikesol/lilypond-reg/scripts/build/out/output-distance", line
321, in string_to_tup
return tuple (map (float, s.split (' ')))
ValueError: invalid literal for float(): +nan.0
_______________________________________________
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond