Comment #10 on issue 2171 by d...@gnu.org: Patch: Implements DOM-id property for grobs.
http://code.google.com/p/lilypond/issues/detail?id=2171
Mike: again, I am not proud of my performance here. But where is the point of a review where the issue, the review description, and the code contain not a single word about what problem they intend to address? Where is the point in adding a user (or application programmer) feature without a regtest and without any documentation?
No, I don't consider "The ID of a DOM node in an XML document." on a property sufficient documentation. There is not a single comment in the whole commit, anything that would even tell somebody reading the code what this is supposed to do and how, The only piece of documentation is the quoted string above.
I don't see how this is anything but dead code and a maintenance burden for anybody but the original author. Yes, I should have hollered the moment it started "review" (how do you review an issue without any more information than the issue title?).
And it is entirely my fault that I did not holler, and it is an aggravating way in which I try fixing it after the last minute.
But I don't agree with your assessment that there was no reason to holler in the first place.
_______________________________________________ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
