%% "Markus Mauhart" <[EMAIL PROTECTED]> writes: mm> during some long ago experiments with make381beta1 sources I've mm> gathered some questionable code snippets, some maybe bugs, but mm> didnt find the time to discuss them, now I thought better now mm> than even later.
Thanks Markus. You don't have a copy of GNU diff lying around on your Windows system do you? It's much, much simpler for me to see the changes if you send a context (diff -c) or unified (diff -u) output. I'll look at your changes in more detail, but a note or two: mm> Bug ? Is this large enough to hold all necessary differences mm> of type dev_t and ino_t ? If in doubt better use good old BOOL. I think that the compare function is supposed to give the same return value as functions like strcmp() and memcmp(); that is, 0 if the two elements are equal, <0 of the first is less than the second, and >0 if the first is greater than the second. This is used to allow sorting. Looking at the hash.c implementation I see that the compare function actually only tests for equality today so your implementation works for now, but still... mm> * lindex() is redundant. True, although very old systems might not have had memchr() implementations. -- ------------------------------------------------------------------------------- Paul D. Smith <[EMAIL PROTECTED]> Find some GNU make tips at: http://www.gnu.org http://make.paulandlesley.org "Please remain calm...I may be mad, but I am a professional." --Mad Scientist _______________________________________________ Bug-make mailing list Bug-make@gnu.org http://lists.gnu.org/mailman/listinfo/bug-make
