Follow-up Comment #2, bug #39158 (project make):

These may interest you in particular:
[signame.c:247]: (warning) Logical disjunction always evaluates to true: sig >
0 || sig < 32.
    247   if (sig > 0 || sig < NSIG)
    248     return (char *) sys_siglist[sig];

Indeed, I think it should be:
    247   if (sig > 0 && sig < NSIG)
    248     return (char *) sys_siglist[sig];


[remake.c:1402] -> [remake.c:1402]: (style) Same expression on both sides of
'&&'.
   1402       if (mtime != NONEXISTENT_MTIME && file->command_state ==
cs_not_started
   1403           && file->command_state == cs_not_started
   1404           && !file->tried_implicit && file->intermediate)

There's one "file->command_state == cs_not_started" which could be removed but
should it be replaced by something else?

Julien

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?39158>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-make mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/bug-make

Reply via email to