Hi Paul,

Am 03.01.20 um 18:24 schrieb Paul Smith:
Hi Christof; .EXTRA_PREREQS is provided in 4.2.93 please test in your
environment.

Note that I did rework some things to allow it to work with implicit rules
(previously it only worked for explicit rules) although it still can't be
used as a pattern-specific variable: that will require more effort.  Also
some changes were made to make things a bit more efficient.

many thanks for adding this into the release candidate . Again, I very
much appreciate your dedicated work, and even more so after looking at
the extra work that was still needed on your side to make the patch
acceptable for inclusion into GNU make.

By the way, I stumbled into a minor issue entirely unrelated to the
feature above that you may want to fix: The gnulib git repository
referenced in bootstrap seems to have changed its location, so you may
want it to change it accordingly:

   $ git diff bootstrap
   diff --git a/bootstrap b/bootstrap
   index 05808ee..8f52cc1 100755
   --- a/bootstrap
   +++ b/bootstrap
   @@ -47,7 +47,7 @@ PERL="${PERL-perl}"

     me=$0

   -default_gnulib_url=git://git.sv.gnu.org/gnulib
   +default_gnulib_url=https://git.savannah.gnu.org/git/gnulib.git

     usage() {
       cat <<EOF

Furthermore, as running ./bootstrap adds the gnulib directory, it may be
appropriate to add it to .gitignore:

   $ git diff .gitignore
   diff --git a/.gitignore b/.gitignore
   index df60c2c..f03287e 100644
   --- a/.gitignore
   +++ b/.gitignore
   @@ -68,3 +68,4 @@ configh.dos
     make-[0-9]*/
     make-[0-9]*.tar.*
     checkcfg.*.log
   +gnulib

And finally, running ./bootstrap also changes lib/.gitignore and
m4/.gitignore, so you may want to consider to commit these changed versions:

   $ git diff lib/.gitignore m4/.gitignore
   diff --git a/lib/.gitignore b/lib/.gitignore
   index cb391c4..a94190f 100644
   --- a/lib/.gitignore
   +++ b/lib/.gitignore
   @@ -9,3 +9,63 @@
     !/glob.in.h
     /glob.h

   +/Makefile.am
   +/_Noreturn.h
   +/access.c
   +/alloca.c
   +/alloca.in.h
   +/arg-nonnull.h
   +/basename-lgpl.c
   +/c++defs.h
   +/close.c
   +/concat-filename.c
   +/concat-filename.h
   +/dirname-lgpl.c
   +/dirname.h
   +/dosname.h
   +/dup2.c
   +/errno.in.h
   +/error.c
   +/error.h
   +/exitfail.c
   +/exitfail.h
   +/fcntl.c
   +/fcntl.in.h
   +/fd-hook.c
   +/fd-hook.h
   +/filename.h
   +/findprog-in.c
   +/findprog.h
   +/getdtablesize.c
   +/getloadavg.c
   +/getprogname.c
   +/getprogname.h
   +/gettext.h
   +/intprops.h
   +/limits.in.h
   +/malloc.c
   +/msvc-inval.c
   +/msvc-inval.h
   +/msvc-nothrow.c
   +/msvc-nothrow.h
   +/stdbool.in.h
   +/stddef.in.h
   +/stdint.in.h
   +/stdio.in.h
   +/stdlib.in.h
   +/stpcpy.c
   +/strerror-override.c
   +/strerror-override.h
   +/strerror.c
   +/string.in.h
   +/stripslash.c
   +/sys_types.in.h
   +/unistd.c
   +/unistd.in.h
   +/verify.h
   +/warn-on-use.h
   +/xalloc-die.c
   +/xalloc-oversized.h
   +/xalloc.h
   +/xconcat-filename.c
   +/xmalloc.c
   diff --git a/m4/.gitignore b/m4/.gitignore
   index 244385a..be62484 100644
   --- a/m4/.gitignore
   +++ b/m4/.gitignore
   @@ -3,3 +3,47 @@
     !/aclocal.m4
     !/dospaths.m4

   +/00gnulib.m4
   +/absolute-header.m4
   +/access.m4
   +/alloca.m4
   +/asm-underscore.m4
   +/close.m4
   +/dirname.m4
   +/double-slash-root.m4
   +/dup2.m4
   +/eaccess.m4
   +/errno_h.m4
   +/error.m4
   +/extensions.m4
   +/fcntl.m4
   +/fcntl_h.m4
   +/findprog-in.m4
   +/getdtablesize.m4
   +/getloadavg.m4
   +/getprogname.m4
   +/gnulib-common.m4
   +/gnulib-comp.m4
   +/gnulib-tool.m4
   +/host-cpu-c-abi.m4
   +/include_next.m4
   +/limits-h.m4
   +/malloc.m4
   +/msvc-inval.m4
   +/msvc-nothrow.m4
   +/multiarch.m4
   +/off_t.m4
   +/ssize_t.m4
   +/stdbool.m4
   +/stddef_h.m4
   +/stdint.m4
   +/stdio_h.m4
   +/stdlib_h.m4
   +/stpcpy.m4
   +/strerror.m4
   +/string_h.m4
   +/sys_socket_h.m4
   +/sys_types_h.m4
   +/unistd_h.m4
   +/warn-on-use.m4
   +/xalloc.m4

Cheers,

Christof


Reply via email to