Am 24.10.22 um 08:59 schrieb Paul Smith:
> I expect this to be the final release candidate before GNU Make 4.4.
> I will probably allow for testing for about a week.

(I had accidentally posted this yesterday as reply to an older thread, but it 
was meant as feedback to make-4.3.92.)

On macOS, compiling "glob.c" gives these warnings:

  glob.c:823:27: warning: incompatible pointer types passing 'char **' to 
parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types]
            = (char **) realloc (pglob->gl_pathv,
                                 ^~~~~~~~~~~~~~~
                                 *
  glob.c:942:24: warning: incompatible pointer types passing 'char **' to 
parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types]
                = (char **) realloc (pglob->gl_pathv,
                                     ^~~~~~~~~~~~~~~
                                     *
  glob.c:997:39: warning: incompatible pointer types passing 'char **' to 
parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types]
              new_pathv = (char **) realloc (pglob->gl_pathv,
                                             ^~~~~~~~~~~~~~~
                                             *
  glob.c:1388:23: warning: incompatible pointer types passing 'char **' to 
parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types]
        = (char **) realloc (pglob->gl_pathv,
                             ^~~~~~~~~~~~~~~
                             *

but from what Paul said in 
https://lists.gnu.org/archive/html/bug-make/2019-05/msg00017.html

> Argh, another glob.c issue.  I really need to figure out how to update
> to a newer version, preferably without breaking Windows AND pulling in
> 75% of gnulib stuff in the process.

I assume we still have to live with these warnings?

Apart from that, there is only one compiler warning:

  src/getopt.c:685:6: warning: add explicit braces to avoid dangling else 
[-Wdangling-else]
                   else
                   ^

A fix had been posted in 
https://savannah.gnu.org/bugs/?func=detailitem&item_id=58075. That looks like a 
"small effort" change to me, perhaps it can be incorporated into GNU Make 4.4?

Regards, Martin


Reply via email to