Hans de Goede wrote: > On 04/20/2010 08:38 PM, Jim Meyering wrote: >> Hans de Goede wrote: >>> msdos partition tables can contain diagnostics partitions (often used >>> now a days as system recovery partitions). For some users of libparted >>> (ie anaconda) it is usefull to know if a dos partition is a regular >>> partition >>> or a diagnostic partition (see rh bug 534066). >>> >>> * include/parted/disk.h(_PedPartitionFlag): Add PED_PARTITION_DIAG >>> * libparted/disk.c(ped_partition_flag_get_name): Add PED_PARTITION_DIAG >>> * libparted/labels/dos.c: Add support for PED_PARTITION_DIAG flag >>> --- >>> NEWS | 3 +++ >> >> Hi Hans, >> >> Thanks for the new feature. >> All that's left is a test to exercise it. >> Do you have (or can you quickly create) >> a small stand-alone test case? > > I'm afraid I don't have a test case. I was thinking, that maybe we should > change the palo / prep test case you did (thanks for that) into a generic > flags testcase, and test all flags of which only one can be set at a time > in some sort of loop, that would have cought the palo / prep issue,
Good idea. I'll do the above, possibly extracting the list of flag names from the texinfo documentation, ... > and will exercise the new diag flag. ...which reminds me. Would you please amend your change to mention the new "diag" type in the texinfo documentation? > (If you want to make it really good you could do this for different label > types, checking all flags supported for each label type). Let's see how long the above takes, first. _______________________________________________ bug-parted mailing list bug-parted@gnu.org http://lists.gnu.org/mailman/listinfo/bug-parted