Hello again,

Am 26.06.2012 um 16:38 schrieb Chet Ramey:

> On 6/26/12 3:51 AM, Max Horn wrote:

[...]
> 
>> What surprises me is the second change: You also added a "continue" in case 
>> "rl_gather_tyi" did manage to read something. So this would reduce the 
>> number of times the event hook is being called. So I assume this is meant to 
>> fix an issue distinct from the one I reported, respectively to make the 
>> behavior of this loop conform with the expected behavior you just described 
>> (only calling the hook if a rl_gather_tyi completed with a *full* timeout, 
>> no data was read). Correct?
> 
> Yes.  The reason the change was made in the first place is that the hook
> should not be called for each character read.  That's not its purpose, and
> it makes using the timeout more difficult.

OK, thank you very much for the patch and taking the time to give some 
explanations :-).

Is there any chance to get this turned into an official patch for readline 6.2, 
considering the problem it fixes is a major nuisance for people using GNU 
readline 6.2 on Mac OS X?



Cheers,
max
_______________________________________________
Bug-readline mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/bug-readline

Reply via email to