Hi Sergey, On Wed, Mar 04, 2009 at 11:13:12AM +0200, Sergey Poznyakoff wrote: > Solar Designer <[email protected]> ha escrit: > > > I'd like to submit upstream a patch from Openwall GNU/*/Linux that we > > came up with in Nov-Dec 2008, and which we've extensively tested since > > then > > Thanks a lot. These are very reasonable changes. I have one doubt, > though: are you sure that a file disappearing from under the running tar > can be treated as unimportant error, especially when in incremental backup > mode?
As you probably recall, I replied to the above message of yours in early March - but then the discussion appears to have died, and no relevant changes appear to be in the git repository. Any status update? Do you possibly require the patch to be revised in some way (what way?) before you can commit it? My reply was: http://lists.gnu.org/archive/html/bug-tar/2009-03/msg00011.html BTW, one of the changes made with the patch is an obvious bug fix: +++ tar-1.20/src/create.c 2008-12-23 12:18:20 +0000 @@ -1078,7 +1078,7 @@ dump_regular_file (int fd, struct tar_st size_left), quotearg_colon (st->orig_file_name), STRINGIFY_BIGINT (size_left, buf))); - if (! ignore_failed_read_option) + if (! ignore_failed_read_option && exit_status == TAREXIT_SUCCESS) exit_status = TAREXIT_DIFFERS; pad_archive (size_left - (bufsize - count)); return dump_status_short; Perhaps you can start by applying this one? Thanks, Alexander
