Привет! On Wednesday, November 24, 2010, Sergey Poznyakoff wrote: > Bernd Schubert <[email protected]> ha escrit: > > However, the only way to trigger that seems to include the patches from > > RedHat patched tar versions to add --xattr support. > > Since the only way to trigger it is to add a patch, that means that the > patch is not properly written.
I thought about the patch over night and I think there is a combiation of different problems: - The patch does not make sure a single block is used only in start_header(), so with large EAs, it will cause a block overflow. - pax_dump_header_1() does not check either to use a single block only. For complex files with lots of different sparse blocks and so a large sparse map, that also should be a problem. - May pax_dump_header_1() should pad the block with zeros? dump_regular_file() does that. - Silent error on extracting the archive and leaving GNUSparseFile.* files around. Does it not even detect those are sparse files? Cheers, Bernd -- Bernd Schubert DataDirect Networks
