-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi Pavel,

Thanks for the detailed response. I'm not completely sure I applied
the patch correctly, but it seems to have failed. I've attached the
full readout of the patch process though so feel free to tell me if
I've borked the process up by inputting the wrong command somewhere
along the line.

Somewhat oddly, I'm still having trouble with the xattrs even after
activating the --without-xattrs command with ./configure. I've
attached that readout as well.

I think Enigmail is going to go ahead and cryptographically sign
everything I attach, so feel free to ignore those additional
attachments. If they're too annoying let me know and I'll figure out a
way to disable the auto-signing process in these mails.

Cheers,

Dominyk

Sent from Thunderbird for OS X. My PGP public key is automatically
attached to this email.

On 04/08/2014 12:58, Pavel Raiskup wrote:
> On Monday 04 of August 2014 01:23:39 Dominyk Tiller wrote:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
>> 
>> Gnu-Tar seems to have some fairly major build issues on OS X.
>> The previous version installs and works fine
> 
> Dominyk, the previous version 1.27.1 should fail same way, IMO.
> The code for xattrs is there for some time.
> 
> On Sunday 03 of August 2014 23:42:59 Paul Eggert wrote:
>> Dominyk Tiller wrote:
>>> Any ideas on this?
>> 
>> Apparently the OS X folks have a different interface for setxattr
>> etc., one that's not compatible with GNU/Linux.  Please try this
>> to work around the problem: ./configure --without-xattrs
> 
> There is unluckily needed to disable building of xattr-at.c, at
> least temporarily (because that tend to be gnulib candiate).  But
> there needs to be done some additional work (XATTR_NOFOLLOW vs.
> l*attr, etc.).
> 
> Dominyk or Denis, could you check attached patch?  Note that it
> requires autoreconf first.  After that, --without-xattrs for
> configure should not be needed.
> 
> Also cc-ing Anthony, as that patch removes part of his patch needed
> for Gentoo builds (it should not break the build hopefully, but I'm
> not completely sure).
> 
> Pavel
> 
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJT4G26AAoJEIclJNuddDJs8koP/1gg7J1Fglss2wUOlUPL5jfU
HeF+G/XzBQoXyXb0Kec4tKcY0flAmkTxMbGeHBhzYxKJ6UnDBYAlvVAA9Xyo1Cyv
NGXh71rp7f56rhnW42K3iFQtQmap4liOpdkajJcLifIie2n6iGswflbvrR4Z/rNV
v7e6EmsHuyQEN3Z/3ZF2zrBPGDHqjxWKm6dOWTd871xfbLooOfXHBGvgyFwW2Evr
pYArp7MEKO6tkjv7gzlK7lLK7Kcrg4WKyUdB5N14zwL3wKI5UuAaU68tduKB28ud
R0XSS+uDK4d0u/XB1GmGCwbgxmacR7edAa7tlx4CEQAYDpqbHSebF8INJp3yRcik
hxkuYFxN9hur4VxgWHFTjWqtRn3XUJ/TzleUfHccx/O8o7do6u+yQy0BHD/x1/OO
6izn23kNg0i8lUErnTcjPXYRjwfcLmyI5FtMKAuksUtUvoN1duPJ0ZfPJv0F2RET
2yer6Wk1JpU3fI+g5G3tbnBff1CHGRYKH+/FuaNYxdDwkXHR6kLO7BUt97t/Kfz+
qMqrxZmbOGsAEVlYCR7wrdhY1FFmvK1iLzlrmSZagMDl5mxdC1LT3+wa1TZ9Hq5G
iZCm95y4XGsoOaoQAkIHgPPxi+lJERbqjymeuzZTqcTB2lvwKijJshaHhDKALcBO
BPPs+9fAPr+6wTjt6GAe
=0rD9
-----END PGP SIGNATURE-----
In file included from xattr-at.c:40:
../gnu/at-func.c:77:12: error: too few arguments to function call, expected 6, have 5
    return CALL_FUNC (file);
           ^~~~~~~~~~~~~~~~
../gnu/at-func.c:46:60: note: expanded from macro 'CALL_FUNC'
# define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
                       ~~~~~~~~~~                          ^
/usr/include/sys/xattr.h:65:1: note: 'setxattr' declared here
int setxattr(const char *path, const char *name, const void *value, size_t size, u_int32_t position, int options);
^
In file included from xattr-at.c:40:
../gnu/at-func.c:95:35: error: too few arguments to function call, expected 6, have 5
        FUNC_RESULT proc_result = CALL_FUNC (proc_file);
                                  ^~~~~~~~~~~~~~~~~~~~~
../gnu/at-func.c:46:60: note: expanded from macro 'CALL_FUNC'
# define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
                       ~~~~~~~~~~                          ^
/usr/include/sys/xattr.h:65:1: note: 'setxattr' declared here
int setxattr(const char *path, const char *name, const void *value, size_t size, u_int32_t position, int options);
^
In file included from xattr-at.c:40:
../gnu/at-func.c:132:9: error: too few arguments to function call, expected 6, have 5
  err = CALL_FUNC (file);
        ^~~~~~~~~~~~~~~~
../gnu/at-func.c:46:60: note: expanded from macro 'CALL_FUNC'
# define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
                       ~~~~~~~~~~                          ^
/usr/include/sys/xattr.h:65:1: note: 'setxattr' declared here
int setxattr(const char *path, const char *name, const void *value, size_t size, u_int32_t position, int options);
^
In file included from xattr-at.c:65:
../gnu/at-func.c:77:12: error: too few arguments to function call, expected 6, have 4
    return CALL_FUNC (file);
           ^~~~~~~~~~~~~~~~
../gnu/at-func.c:46:60: note: expanded from macro 'CALL_FUNC'
# define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
                       ~~~~~~~~~~                          ^
/usr/include/sys/xattr.h:61:1: note: 'getxattr' declared here
ssize_t getxattr(const char *path, const char *name, void *value, size_t size, u_int32_t position, int options);
^
In file included from xattr-at.c:65:
../gnu/at-func.c:95:35: error: too few arguments to function call, expected 6, have 4
        FUNC_RESULT proc_result = CALL_FUNC (proc_file);
                                  ^~~~~~~~~~~~~~~~~~~~~
../gnu/at-func.c:46:60: note: expanded from macro 'CALL_FUNC'
# define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
                       ~~~~~~~~~~                          ^
/usr/include/sys/xattr.h:61:1: note: 'getxattr' declared here
ssize_t getxattr(const char *path, const char *name, void *value, size_t size, u_int32_t position, int options);
^
In file included from xattr-at.c:65:
../gnu/at-func.c:132:9: error: too few arguments to function call, expected 6, have 4
  err = CALL_FUNC (file);
        ^~~~~~~~~~~~~~~~
../gnu/at-func.c:46:60: note: expanded from macro 'CALL_FUNC'
# define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
                       ~~~~~~~~~~                          ^
/usr/include/sys/xattr.h:61:1: note: 'getxattr' declared here
ssize_t getxattr(const char *path, const char *name, void *value, size_t size, u_int32_t position, int options);
^
In file included from xattr-at.c:92:
../gnu/at-func.c:77:12: error: too few arguments to function call, expected 4, have 3
    return CALL_FUNC (file);
           ^~~~~~~~~~~~~~~~
../gnu/at-func.c:46:60: note: expanded from macro 'CALL_FUNC'
# define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
                       ~~~~~~~~~~                          ^
/usr/include/sys/xattr.h:73:1: note: 'listxattr' declared here
ssize_t listxattr(const char *path, char *namebuff, size_t size, int options);
^
In file included from xattr-at.c:92:
../gnu/at-func.c:95:35: error: too few arguments to function call, expected 4, have 3
        FUNC_RESULT proc_result = CALL_FUNC (proc_file);
                                  ^~~~~~~~~~~~~~~~~~~~~
../gnu/at-func.c:46:60: note: expanded from macro 'CALL_FUNC'
# define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
                       ~~~~~~~~~~                          ^
/usr/include/sys/xattr.h:73:1: note: 'listxattr' declared here
ssize_t listxattr(const char *path, char *namebuff, size_t size, int options);
^
In file included from xattr-at.c:92:
../gnu/at-func.c:132:9: error: too few arguments to function call, expected 4, have 3
  err = CALL_FUNC (file);
        ^~~~~~~~~~~~~~~~
../gnu/at-func.c:46:60: note: expanded from macro 'CALL_FUNC'
# define CALL_FUNC(F) (AT_FUNC_F1 (F AT_FUNC_POST_FILE_ARGS))
                       ~~~~~~~~~~                          ^
/usr/include/sys/xattr.h:73:1: note: 'listxattr' declared here
ssize_t listxattr(const char *path, char *namebuff, size_t size, int options);
^
9 errors generated.
make[2]: *** [xattr-at.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [install] Error 2
make: *** [install-recursive] Error 1
➜  Downloads  cd tar-1.28
➜  tar-1.28  patch --verbose -i /Users/test/Downloads/0001-xattrs-fix-bug-in-configure.patch
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
| acinclude.m4    | 42 ++++++++++++++----------------------------
| lib/xattr-at.c  |  7 +++++++
| src/Makefile.am |  4 ----
| 3 files changed, 21 insertions(+), 32 deletions(-)
|
|diff --git a/acinclude.m4 b/acinclude.m4
|index 3b28b3b..db0bbc7 100644
|--- a/acinclude.m4
|+++ b/acinclude.m4
--------------------------
Patching file acinclude.m4 using Plan A...
Hunk #1 succeeded at 40.
Hmm...  The next patch looks like a unified diff to me...
can't find file to patch at input line 66
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/lib/xattr-at.c b/lib/xattr-at.c
|index 443ccae..009bde5 100644
|--- a/lib/xattr-at.c
|+++ b/lib/xattr-at.c
--------------------------
File to patch: /Users/test/Downloads/tar-1.28/lib/xattr-at.c
Patching file /Users/test/Downloads/tar-1.28/lib/xattr-at.c using Plan A...
Hunk #1 succeeded at 18.
Hunk #2 succeeded at 113.
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------
|diff --git a/src/Makefile.am b/src/Makefile.am
|index 82b2d46..42daaef 100644
|--- a/src/Makefile.am
|+++ b/src/Makefile.am
--------------------------
Patching file Makefile.am using Plan A...
Hunk #1 FAILED at 52.
1 out of 1 hunk FAILED -- saving rejects to file Makefile.am.rej
Hmm...  Ignoring the trailing garbage.
done

-----------------------------------------------------------------------------
➜  tar-1.28  autoreconf
src/Makefile.am:56: error: TAR_LIB_ATTR does not appear in AM_CONDITIONAL
autoreconf: automake failed with exit status: 1

Attachment: 0x9D74326C.asc
Description: application/pgp-keys

Attachment: makeerrors.md.sig
Description: Binary data

Attachment: patchresult.md.sig
Description: Binary data

Attachment: 0x9D74326C.asc.sig
Description: Binary data

Reply via email to