On 08/22/2017 01:03 PM, Sven C. Dack wrote:
> Hello,
>
> I'm sending you an updated patch against the current git master. Note,
> in addition to supporting lz4 and zstd does it add a single 'break;'
> into tar.c at line 1130:
>
> case LZOP_OPTION:
> s = xasprintf (_("filter the archive through %s"), LZOP_PROGRAM);
> + break;
>
> which previously caused the case to fall-through and for the --help
> option to print a wrong message regarding what gets filter through which
> compression tool. Because it's a single, missing break-statement did I
> not create an extra patch for it.On the other hand, a separate commit for every bug is a GOOD policy to abide by, as it makes life easier for downstream distros that want to backport bug fixes but not features. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
