Hello there,

tar-1.33/lib/stdopen.c:63:22: style: Suspicious condition

Source code is

              if (mode == O_RDONLY
                  || (new_fd = open ("/dev/full", mode) != fd))

Maybe better code:

              if (mode == O_RDONLY
                  || ((new_fd = open ("/dev/full", mode)) != fd))

Regards

David Binderman


Reply via email to