On 2/6/2016 2:32 PM, Gavin Smith wrote:
On 6 February 2016 at 19:14, Eli Zaretskii <e...@gnu.org> wrote:
We have released Texinfo 6.1, the GNU documentation format.
Thanks.
I had the compilation warnings shown at the end of this message when
building this with MinGW on MS-Windows.
I ignored the realloc warnings: they seem to be due to fighting
between Gnulib redefinitions and Perl headers redefinitions, and I see
no way of avoiding them. They also seem harmless.
Seems harmless to me as well.
The popen/pclose issue seems more serious; I fixed it like this:
--- tp/Texinfo/Convert/XSParagraph/xspara.c~0 2016-01-23 13:31:17.000000000
+0200
+++ tp/Texinfo/Convert/XSParagraph/xspara.c 2016-02-06 20:30:33.083250000
+0200
@@ -198,6 +198,16 @@ iswupper (wint_t wc)
return 1;
}
+/* Avoid warnings due to redefinition of popen/pclose in Perl headers. */
+#ifdef popen
+# undef popen
+# define popen(c,m) _popen(c,m)
+#endif
+#ifdef pclose
+# undef pclose
+# define pclose(f) _pclose(f)
+#endif
+
#endif
I see this code is in the #ifdef _WIN32 section, so I'm happy with it
even if I don't understand it.
One worry I have is why Perl is redefining popen/pclose in the first
place and if problems could occur on other systems, like Cygwin. (Ken
cc'd).
No, I don't get any such warnings on Cygwin.
Ken
