> From: Gavin Smith <[email protected]> > Date: Sat, 22 Oct 2022 11:54:47 +0100 > Cc: Patrice Dumas <[email protected]>, [email protected] > > It would take investigating each of the redefined functions, and whether > they need to be redefined by the Gnulib modules in use, to have similar > fixes this time. Or the simpler fix is to #undef them all, as you did.
It's fine by me to use the simple fix I did. Please install the changes, if you agree. > I believe it is the Perl versions we should be using, not the Gnulib > versions, in the case of any conflict. Yes, of course. On Windows in particular, we cannot possibly use the Gnu replacements in this case. > > The next problem is in api.c: several functions were missing the dTHX > > thingy. Here's the patch: > > Thanks, applied. Thanks. > > And now for the final blow: while building texinfo.info, I get this > > error message: > > > > Can't locate I18N/Langinfo.pm in @INC (you may need to install the > > I18N::Langinfo module) (@INC contains: d:/usr/Perl/site/lib d:/usr/Perl/lib > > .) at ../tp/texi2any line 29. > > BEGIN failed--compilation aborted at ../tp/texi2any line 29. > > Makefile:1547: recipe for target `texinfo.info' failed > > make[3]: *** [texinfo.info] Error 2 > > I'm optimistic that this can be fixed - we can check for the module > when texi2any is run and make accommodations if it can't be loaded. Yes, it sounds like this is the best way forward.
