* Gavin Smith: > On Wed, Apr 19, 2023 at 05:59:31PM +0200, Arsen Arsenović wrote: >> >> [CC += Patrice as the author of the original patch] >> >> Arsen Arsenović <ar...@aarsen.me> writes: >> >> > To my untrained-to-the-parser eyes, it seems like the parser is trying >> > to parse @end as part of @item and getting confused (whereas the >> > unaffected version parses @item first, with no argument, and then @end). >> > >> > I'll try to bisect and come up with a fix. Everyone should feel free to >> > beat me to it, though. >> >> It appears that b225268a2ecdc58a06faa73c629ae1810942989f fixed this >> issue on master. > > Thanks for tracking it down. > > I am not going to try to understand the patch and decide whether > it is correct for the release branch. In general, there may have > been other changes on the master branch that this patch relied on. > > I think we should only include this patch if: > > * Patrice thinks it is okay for the release branch; and > * The bug is important enough to fix in a bug-fix release, when balanced > against the complexity of the change and the risk of introducing further > bugs (which I doubt).
If it's about better errors for invalid input, then it doesn't seem very important to b ackport, especially if output generation fails anyway. (Sorry, I didn't quite understand the nature of the issue; the minimized reproducer does look invalid to me.) Thanks, Florian