Re: texinfo does not compile without libintl.h even though configure checks for it

[Gavin Smith]

On Mon, Jan 29, 2024 at 01:10:52AM +0000, Erik A Johnson wrote:
> Without libintl.h, tp/Texinfo/XS/parsetexi/api.c does not compile -- even 
> though configure tests for libintl.h.  In api.c, is the line
> 
>       #include <libintl.h>
> 
> actually needed?  (Commenting that line out in texinfo-7.1 allows it to 
> compile, complete tests, etc. on macOS Sonoma 14.2.1.)
> 
> 

Possibly not.  In the development code some of the code from api.c was
moved to tp/Texinfo/XS/main/build_perl_info.c and there, the #include line
is surrounded by an #ifdef block:

#ifdef ENABLE_NLS
#include <libintl.h>
#endif

This change was made on 2023-08-14.  ChangeLog entry:


2023-08-14  Patrice Dumas  <pertu...@free.fr>

        * tp/Texinfo/XS/parsetexi/build_perl_info.c: include libintl.h only
        if ENABLE_NLS.

        * tp/Texinfo/XS/parsetexi/build_perl_info.h: do not include errors.h.