On Wed, Nov 20, 2024 at 09:36:14PM +0000, Gavin Smith wrote:
> I've committed changes to do this. I had to override and revert
> a commit you made before that as it clashed with my changes - I needed
> the $additional_libraries argument which you had removed.
This works well in the CI, all the platforms that did not now use the XS
modules. Thanks!
When the libraries are installed, I think that it could be possible that
there are no .la files. So, maybe, if
!$Texinfo::ModulePath::texinfo_uninstalled it would be better not to
fallback if the library is not found. Something like:
if ($additional_libraries) {
for my $additional_library_name (@{$additional_libraries}) {
my $additional_library = 'lib' . $additional_library_name;
if (!$loaded_additional_libraries->{$additional_library}) {
my $ref = load_libtool_library($additional_library);
if (!$ref) {
if (!$Texinfo::ModulePath::texinfo_uninstalled) {
goto FALLBACK;
}
} else {
$loaded_additional_libraries->{$additional_library} = $ref;
}
}
}
}
Would that be ok?
--
Pat
