On Thu, Jan 29, 2026 at 09:03:17PM +0000, Gavin Smith wrote:
> On Tue, Jan 27, 2026 at 11:03:08PM +0100, [email protected] wrote:
> > Maybe if disable XS is set and --enable-additional-checks is not passed
> > we would not recurse in tta/C?
> > 
> > As a side note, the SWIG python interface can be built with disable XS,
> > so it would need the same conditionals.
> 
> I'm guessing this is the change that should be made but I will leave it
> to you to commit it if necessary as I don't know enough about the
> SWIG interface:

I preferred checking BUILD_C_CODE in the parent directory Makefile.am,
as it should be needed for all the SWIG interfaces.  What is actually
tested is probably only if iconv is present, but it is probably clearer
to use BUILD_C_CODE.

> diff --git a/tta/swig/Makefile.am b/tta/swig/Makefile.am
> index 52e5dd506b..7ed5bc2ceb 100644
> --- a/tta/swig/Makefile.am
> +++ b/tta/swig/Makefile.am
> @@ -15,7 +15,7 @@ SUBDIRS += perl
>  endif
>  
>  if SWIG_PYTHON_INTERFACE
> -if DISABLE_XS
> +if !BUILD_C_CODE
>  SUBDIRS += python
>  else
>  # linking with libperl is needed if there is C Perl code in Texinfo libraries
> 

Reply via email to