Hi Darshit,
Darshit Shah <dar...@gmail.com> writes:
> I have implemented a --method command along with --body-data and --body-file
> commands for HTTP Scripting.
>
> Have attached the patch alongwith this mail. However, this is not complete,
> not to my satisfaction atleast.
> There is redundant code that executes the old --post-data and --post-file
> commands.
great work! Just some comments:
+ else if (opt.method)
+ {
+ char *q;
+ int s = strlen (opt.method);
+ for ( q = opt.method; s>=0; ++q, s-- )
+ *q = c_toupper (*q);
+ meth = opt.method;
+ }
this could be simplified as:
for (q = opt.method; *q; ++q)
then you don't need s at all.
The new flags should be documented, could you add also the documentation
for those?
Cheers,
Giuseppe
