Hi, Jure. On 1 April 2014 03:46, Jure Grabnar <grabna...@gmail.com> wrote: > Hello, > > thanks for your feedback! I corrected the first patch.
Then the 1st one is fine with me. I am not fluent with Metalink and libmetalink on how it handles the type attribute. In version 4.0 of the standard, there is no type attribute for metalink:url element, only metalink:metaurl has it. Though not explicitly using a word like "must" in version 3.0 of the spec, looks like type attribute is a required one there (See 4.1.2.4 of the 3.0 spec). If that is the case, then the metalink file is not a standard-compliant one if that attribute is missing. Maybe later people want a way to ignore those non-compliant metalink:url element. But let that be another story when the need actually came up. :) yousong