Has anyone tested out this patch yet? I'd really like some feedback on this before it gets merged. I prefer this implementation of the progress bar over the original one. Does anybody have any issues / suggestions?
On Sat, May 24, 2014 at 12:12 PM, Darshit Shah <[email protected]> wrote: > Thanks for all the suggestions. Here is the final version of the > patch. Do test it out and let me know if anything is amiss / something > would look better if changed. > > > On Tue, May 20, 2014 at 12:22 PM, Giuseppe Scrivano <[email protected]> wrote: >> Darshit Shah <[email protected]> writes: >> >>> On Tue, May 20, 2014 at 1:26 AM, Ángel González <[email protected]> wrote: >>>> On 19/05/14 21:17, Darshit Shah wrote: >> >>>>> 2. I am not aware of anyone parsing the output of Wget's progress bar. >>>>> Do you think changing the default output would cause a problem? >>>> >>>> No. >>> Thought so, needed secondary confirmation >> >> and I think we don't care. People shouldn't parse the progress bar. If >> someone wants this information then we should look for another way to >> offer it. >> >>>>> 3. Should we add some kind of --human-readable option to toggle >>>>> between bytes output and human readable output? >>>> >>>> I don't like dozens of options just to control the progress bar. I wouldn't >>>> add >>>> it yet. Maybe if we later see a need for it. >>>> >>> Yes, even I believe there are too many options for controlling the >>> progress bar's output. I'll just make this the default, if people >>> complain, we can add a switch. >> >> agree :-) >> >> Cheers, >> Giuseppe > > > > -- > Thanking You, > Darshit Shah -- Thanking You, Darshit Shah
