Then I guess we should push this patch. I don't think there are many HTTP/1.0 servers around anymore, and if Wget fails on any of them, it's because they're misconfigured.
On Mon, Jun 16, 2014 at 4:41 PM, Schroeteler, Thorsten <[email protected]> wrote: > Hello Giuseppe, > > Yes it works like you suggest: > > request_set_header (req, "Connection", "Keep-Alive", rel_none); > request_set_header (req, "Proxy-Connection", "Keep-Alive", rel_none); > > The important thing seems that "Connection" is not closed. > > Cheers, > Thorsten > > > -----Original Message----- > From: Giuseppe Scrivano [mailto:[email protected]] > Sent: Monday, June 16, 2014 12:26 PM > To: Darshit Shah > Cc: Schroeteler, Thorsten; bug-wget > Subject: Re: [Bug-wget] wget - cntlm incompatibility (wget 1.13 onwards) > > Darshit Shah <[email protected]> writes: > >>> In wget-1.13 if I replace the two request_set_header calls in http.c >>> (line 1683,1684) with one >>> for "Connection" "Keep-Alive" then the download is successful: >>> >>> if (inhibit_keep_alive) >>> request_set_header (req, "Connection", "Close", rel_none); >>> else >>> { >>> if (proxy == NULL) >>> request_set_header (req, "Connection", "Keep-Alive", > rel_none); >>> else >>> { >>> //request_set_header (req, "Connection", "Close", > rel_none); >>> //request_set_header (req, "Proxy-Connection", > "Keep-Alive", >>> rel_none); >>> request_set_header (req, "Connection", "Keep-Alive", >>> rel_none); >>> } >>> } >>> >>> >>> I don't know whether this is rather a wget or an cntlm issue. I will >>> post this to the cntlm mailing list as well. >>> Any help is appreciated (it would be nice if we don't need to patch > wget >>> in future ...). >>> >> >> Hi Thorsten, >> >> Sorry for the delay in responding and thanks for reporting this to us. >> This does indeed look like a bug to me. When inhibit_keep_alive is not >> set, Wget should indeed be sending a Connection: Keep-Alive header and >> not close the connection. Unless there is some specification about >> working with proxies that I forget. >> >> I think this is a bug and needs to be fixed with the above provided >> solution. Does anyone here object? > > From the ChangeLog file, it seems that Proxy-Connection was introduced > to fix a problem with some HTTP/1.0 proxies. > > Thorsten, does it work if we leave both headers set like the following? > > request_set_header (req, "Connection", "Keep-Alive", rel_none); > request_set_header (req, "Proxy-Connection", "Keep-Alive", rel_none); > > Regards, > Giuseppe -- Thanking You, Darshit Shah
