I've tried to explain the context behind each patch below and have also resent the version of each patch I had locally to the relevant threads. So, I'm sorry for spamming your mailboxes.
1. Fix make distcheck for Python testsTim discovered that the Python based test suite wasn't passing make distcheck due to a variety of reasons. I've fixed most of all the issues with the code.
Some hacks still need to be eliminated. But in general, everything works right now. 2. Minor optimizations of Python tests While working with the Python test suite to fix the above mentioned issues, I came across and fixed some inefficiencies / cruft code in the test suite. Those have been eliminated in this patch. 3. Fixed IRI misbehaviors Wget wasn't functioning correctly with non "C" locales. Tim has fixed the issue but the patch hasn't yet been pushed. 4. Add ./configure valgrind support to test suites Tim added support for finding and fixing memory leaks in Wget by running the entire Perl based test suite under Valgrind. This feature had already been implemented in the python tests earlier. There's still rough edges to this patch that need fixing, so it may not be ready for merging right now. Current Issues ============== Test-proxied-https-auth.px fails more than 9/10 times when executed through make check. However when executed directly as ./Test-proxied-https-auth.px, it works perfectly. It also works perfectly when executed through a make check -jn command. So, it seems to be some sort of a race condition that requires to be identified. Side Note ========= During the various discussions across multiple threads for these patches, we discovered various ways of executing make check, make distcheck, and each test which had to be checked manually to ensure that everything was working fine. For example, Tim made a very nice list during one of the discussions: - make check - make check -jn - cd tests; ./Test-... - make distcheck - make distcheck -jn - TESTS_ENVIRONMENT="LC_ALL=whatever" make check [-jn] - cd tests; TESTS_ENVIRONMENT="LC_ALL=whatever" ./Test-... (i used to test LC_ALL=tr_TR.utf8 for TESTS_ENVIRONMENT) Maybe we could automate all of these under a single make target? Or else, I intend to set up a Travis CI build every week to run these tests. What is everyone's opinion on this? -- Thanking You, Darshit Shah
pgpcxSpyZbIqn.pgp
Description: PGP signature