On Tuesday 16 December 2014 00:26:35 Jérémie Courrèges-Anglas wrote: > Hi, > > in src/warc.c three methods are provided to generate uuids: libuuid, > uuid functions from libc, and a fallback method. At least OpenBSD, > FreeBSD and NetBSD provide those uuid functions in their libc. > > http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man3/uuid.3 > > This diff fixes the detection and use of those functions. It does not > change the fact that libuuid is always preferred if present and not > explicitely disabled.
Thanks for your contribution !
It looks like a good opportunity to fix ./configure's libuuid detection.
We just have to agree on an approach.
Suggestion:
if --with-libuuid explicitly specified
search for libuuid (pkg-config or fallback to AC_SEARCH_LIBS)
if not found print error and stop
else
search for uuid_create (AC_CHECK_FUNC)
if not found
if --without-libuuid explicitly specified
use fallback code
else
search for libuuid (pkg-config or fallback to AC_SEARCH_LIBS)
if not found
use fallback code
What do you think ?
Would you like to amend your patch or should I do it ?
Tim
signature.asc
Description: This is a digitally signed message part.
