Miquel Llobet <mllobet...@gmail.com> writes: > removed braces from the second if statement, as per GNU's coding standards > > --- src/log.c.origin 2015-03-13 01:32:27.000000000 +0100 > +++ src/log.c 2015-03-13 02:28:25.000000000 +0100 > @@ -598,11 +598,16 @@ > { > if (file) > { > - logfp = fopen (file, appendp ? "a" : "w"); > - if (!logfp) > + if (HYPHENP (file)) > + logfp = stdout; > + else > { > - fprintf (stderr, "%s: %s: %s\n", exec_name, file, strerror > (errno)); > - exit (WGET_EXIT_GENERIC_ERROR); > + logfp = fopen (file, appendp ? "a" : "w"); > + if (!logfp) > + { > + fprintf (stderr, "%s: %s: %s\n", exec_name, file, strerror > (errno)); > + exit (WGET_EXIT_GENERIC_ERROR); > + } > } > } > else
It seems like the correct thing to do. Could you please just use as ChangeLog-style like commit message? Thanks, Giuseppe