These are some valid corner cases. I'll also add a few invalid inputs to stress that function.
Thanking You, Darshit Shah Sent from mobile device. Please excuse my brevity On 30-Aug-2015 12:51 am, "Tim Rühsen" <[email protected]> wrote: > Am Samstag, 29. August 2015, 23:13:23 schrieb Darshit Shah: > > I've written a unit test for the parse_content_range() method. > > However, I haven't yet populated it with various test cases. > > Sharing the patch for the unit test here. I will add more test cases > > for this test later. > > > > Kindly do review the patch. If no one complains, I'll push it in a > > couple of days. > > Hi Darshit, > > some of the 'valid' tests > > 0-max > { "bytes 0-1000/1000", 0, 1000, 1000} > non0-max > { "bytes 1-1000/1000", 1, 1000, 1000} > 0-valid > { "bytes 0-500/1000", 0, 500, 1000} > non0-valid > { "bytes 1-500/1000", 1, 500, 1000} > 0-(max-1) > { "bytes 0-999/1000", 0, 999, 1000} > non0-(max-1) > { "bytes 1-999/1000", 1, 999, 1000} > > And please add some tests using >=2^31 and >=2^32 as values. > > Regards, Tim >
