Am Freitag, 18. Dezember 2015, 16:42:15 schrieb Giuseppe Scrivano: > Eli Zaretskii <e...@gnu.org> writes: > > Attached. > > great, thanks! Tim, do you have any objections or can we push it?
Just two issues. 1. Maybe do_conversion() should take a char * argument instead of const char *. We avoid one ugly const -> non-const cast an also a warning about iconv. 2. contrib/check-hard fails with TESTS_ENVIRONMENT="LC_ALL=tr_TR.utf8 VALGRIND_TESTS=0" make check FAIL: Test-iri-forced-remote My son has birthday tomorrow, so I am not sure how much time I can spend on the weekend on this issue. Maybe Eli or you could have a look ? Regards, Tim
