On Tue, Feb 14, 2017 at 04:03:13PM +0000, Adam Sampson wrote:
> Your patch compiles, but doesn't fix the broken test. tcpdump traces
> attached of the test succeeding and failing with the patch applied (it's
> exactly the same behaviour as before).

If it helps: here's a patch to the test server to add a delay after
sending the headers -- this makes it always fail (on the second request)
for me, even on a fast AMD64 machine.

Thanks,

-- 
Adam Sampson <[email protected]>                         <http://offog.org/>
--- testenv/server/http/http_server.py  2016-02-24 19:40:07.000000000 +0000
+++ testenv/server/http/http_server.py  2017-02-14 16:16:02.496607405 +0000
@@ -8,6 +8,8 @@
 import threading
 import socket
 import os
+import time
+import sys
 
 
 class StoppableHTTPServer(HTTPServer):
@@ -205,6 +207,9 @@
     def Response(self, resp_obj):
         self.send_response(resp_obj.response_code)
         self.finish_headers()
+        print("Sleeping after sending headers...", file=sys.stderr)
+        time.sleep(3.0)
+        print("... continuing", file=sys.stderr)
         if resp_obj.response_code == 304:
             raise NoBodyServerError("Conditional get falling to head")
         raise ServerError("Custom Response code sent.")

Attachment: signature.asc
Description: PGP signature

Reply via email to