[Bug-wget] inet_ntop() in mswindows.c

[Gisle Vanem]

Just a detail, but in src/mswindows.c, there is:

  #ifdef ENABLE_IPV6
  /* An inet_ntop implementation that uses WSAAddressToString.
     Prototype complies with POSIX 1003.1-2004.  This is only used under
     IPv6 because Wget prints IPv4 addresses using inet_ntoa.  */

This is wrong since 1) inet_ntoa() is no longer used. And 2) since
inet_ntop() is used for IPv4 too, 'ENABLE_IPV6' should then become
'!defined(HAVE_INET_NTOP)'. Thus:

@@ -572,10 +572,10 @@
 }


-#ifdef ENABLE_IPV6
+#if !defined(HAVE_INET_NTOP)
 /* An inet_ntop implementation that uses WSAAddressToString.
-   Prototype complies with POSIX 1003.1-2004.  This is only used under
-   IPv6 because Wget prints IPv4 addresses using inet_ntoa.  */
+   Prototype complies with POSIX 1003.1-2004.  This is used
+   for both IPv4 and IPv6.  */

 const char *
 inet_ntop (int af, const void *src, char *dst, socklen_t cnt)

--gv