On Donnerstag, 2. November 2017 21:09:46 CET YX Hao wrote: > Dear Tim, > > > > The 2nd patch is attached. Please take a review :)
Hmmm, is this a stand-alone patch and working without your patch #1 (Fix printing...) ? Please give at least one example (better more) to show what your patch fixes. Even better: write a small python test in testenv which fails without your patch and succeeds with your patch. That would protect against regressions. As I understand, the second patch is still in discussion with Eli. Since I do not have Windows, I can't help you here. Though what I saw from the discussion, you address a portability issue that likely should be solved within gnulib. Maybe you could (in parallel) send a mail to bug-gnu...@gnu.org with a link to your discussion with Eli. There might be some people with deeper knowledge. With Best Regards, Tim
signature.asc
Description: This is a digitally signed message part.
