Re: [Bug-wget] Error when compiling wget 1.19.5 with c-ares 1.14.0

[Tim Rühsen]

On 06/04/2018 01:14 PM, Krzysztof Malinowski wrote:
> Hello,
> 
> I am trying to build wget 1.19.5 with c-ares 1.14.0 and the
> compilation fails with error:
> 
> make[3]: Entering directory '/dev/shm/akm022/wget-1.19.5/src'
>   CC       host.o
> host.c: In function 'wait_ares':
> host.c:735:11: error: void value not ignored as it ought to be
>      timer = ptimer_destroy (timer);
>            ^
> make[3]: *** [Makefile:1687: host.o] Error 1
> 
> wget was configured with:
> 
> ./configure --prefix=/proj/subcm/tools/Linux-x86_64
> LDFLAGS='-Wl,-rpath,\$ORIGIN:\$ORIGIN/../lib64:\$ORIGIN/../Tikanga/lib64
> -Wl,-z,origin' --with-ssl=openssl --with-cares
> 
> GCC used is 8.1.0.
> 
> It seems that the fix should be quite trivial, could we get this fixed
> in the source code? If I could be of any help for fixing that, please
> let me know.

Hi,

it was the first thing fixed after the 1.19.5 release. So if you git
clone, the problem is solved.

But instead you can simply apply this change:

@@ -732,7 +732,7 @@ wait_ares (ares_channel channel)
         ares_process (channel, &read_fds, &write_fds);
     }
   if (timer)
-    timer = ptimer_destroy (timer);
+    ptimer_destroy (timer);
 }

 static void

(Just remove 'timer = ' and that's it.)


Regards, Tim

signature.asc
Description: OpenPGP digital signature